Skip to content

Derive Default for QueryArenas#151445

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Zalathar:arenas-default
Jan 21, 2026
Merged

Derive Default for QueryArenas#151445
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Zalathar:arenas-default

Conversation

@Zalathar
Copy link
Member

There's no need to manually implement Default for this struct, because the fields are all TypeArena<_> or (), which both implement Default already.

This lets us avoid one occurrence of the query_if_arena! macro.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 21, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@mati865
Copy link
Member

mati865 commented Jan 21, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

📌 Commit 2495e58 has been approved by mati865

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
@mati865
Copy link
Member

mati865 commented Jan 21, 2026

@bors rollup

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 21, 2026
Derive `Default` for `QueryArenas`

There's no need to manually implement Default for this struct, because the fields are all `TypeArena<_>` or `()`, which both implement Default already.

This lets us avoid one occurrence of the `query_if_arena!` macro.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 21, 2026
Derive `Default` for `QueryArenas`

There's no need to manually implement Default for this struct, because the fields are all `TypeArena<_>` or `()`, which both implement Default already.

This lets us avoid one occurrence of the `query_if_arena!` macro.
rust-bors bot pushed a commit that referenced this pull request Jan 21, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #147426 ( tests/debuginfo/basic-stepping.rs: Add revisions `default-mir-passes`, `no-SingleUseConsts-mir-pass`)
 - #150880 (Remove old error emitter)
 - #151432 (use `deny(missing_docs)` for non-mir intrinsics)
 - #151444 (Move UI tests)
 - #151445 (Derive `Default` for `QueryArenas`)
 - #151453 (make `simd_insert_dyn` and `simd_extract_dyn` const)

r? @ghost
@rust-bors rust-bors bot merged commit f87b84c into rust-lang:main Jan 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
rust-timer added a commit that referenced this pull request Jan 21, 2026
Rollup merge of #151445 - Zalathar:arenas-default, r=mati865

Derive `Default` for `QueryArenas`

There's no need to manually implement Default for this struct, because the fields are all `TypeArena<_>` or `()`, which both implement Default already.

This lets us avoid one occurrence of the `query_if_arena!` macro.
@Zalathar Zalathar deleted the arenas-default branch January 21, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants