Rollup of 2 pull requests#151452
Closed
JonathanBrouwer wants to merge 6 commits intorust-lang:mainfrom
Closed
Conversation
…nore-*` We want directives nice and tidy.
…, `no-SingleUseConsts-mir-pass` To prevent regressions our test must cover the code both inside and outside of the `SingleUseConsts` MIR pass. Use revisions for that.
tests/debuginfo/basic-stepping.rs: Add revisions `default-mir-passes`, `no-SingleUseConsts-mir-pass` To prevent regressions our test must cover the code both inside and outside of the `SingleUseConsts` MIR pass. Use revisions for that. We know this use case is sensitive to regressions because it already happened at least once. See rust-lang#33013 (comment). CC rust-lang#130896
Derive `Default` for `QueryArenas` There's no need to manually implement Default for this struct, because the fields are all `TypeArena<_>` or `()`, which both implement Default already. This lets us avoid one occurrence of the `query_if_arena!` macro.
rustbot
added
S-waiting-on-review
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
default-mir-passes,no-SingleUseConsts-mir-pass#147426 ( tests/debuginfo/basic-stepping.rs: Add revisionsdefault-mir-passes,no-SingleUseConsts-mir-pass)DefaultforQueryArenas#151445 (DeriveDefaultforQueryArenas)r? @ghost
Create a similar rollup