Skip to content

Update documentation for Result::ok()#151974

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
clundin55:doc-fix
Feb 3, 2026
Merged

Update documentation for Result::ok()#151974
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
clundin55:doc-fix

Conversation

@clundin55
Copy link
Contributor

@clundin55 clundin55 commented Feb 2, 2026

The term of "discard" is misleading. An error is not discarded but converted to an Option::None.

@clundin55
Update documentation for Result::ok()
f3b7a1a 
The term of "discard" is misleading. An error is not discarded but
converted to an `Option::None`.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 2, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 2, 2026

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jhpratt
Copy link
Member

jhpratt commented Feb 2, 2026

While I personally disagree with the premise (I find "discard" to be accurate and descriptive), I understand that this could conceivably be confusing for some.

r? jhpratt
@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 2, 2026

📌 Commit f3b7a1a has been approved by jhpratt

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 2, 2026
@rust-bors rust-bors bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 2, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 2, 2026
@jhpratt
Rollup merge of rust-lang#151974 - clundin55:doc-fix, r=jhpratt
b38f7a2 
Update documentation for `Result::ok()`

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
@jhpratt jhpratt mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151984 - jhpratt:rollup-OHZj4tL, r=jhpratt
1626a9e 
Rollup of 5 pull requests

Successful merges:

 - #151825 (more float constants)
 - #151958 (Add codegen test for SLP vectorization)
 - #151974 (Update documentation for `Result::ok()`)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 2, 2026
@jhpratt
Rollup merge of rust-lang#151974 - clundin55:doc-fix, r=jhpratt
2e52598 
Update documentation for `Result::ok()`

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
@jhpratt jhpratt mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151987 - jhpratt:rollup-CkK6vN9, r=jhpratt
6f59a55 
Rollup of 5 pull requests

Successful merges:

 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151825 (more float constants)
 - #151974 (Update documentation for `Result::ok()`)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151974 - clundin55:doc-fix, r=jhpratt
a13e145 
Update documentation for `Result::ok()`

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #151997 - JonathanBrouwer:rollup-txk7tC8, r=JonathanBro…
6ad3d3d 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #150992 (link modifier `export-symbols`: export all global symbols from selected uptream c static libraries)
 - #151695 (compiletest: Support `--extern` modifiers with `proc-macro` directive)
 - #151938 (Use `#![feature(adt_const_params)]` for static query flags)
 - #151172 (Use default field values in a few more cases)
 - #151825 (more float constants)
 - #151870 (regression test for alias-relate changes in lub)
 - #151902 (explain why we dont skip some of this work when there are field projections)
 - #151974 (Update documentation for `Result::ok()`)
 - #151978 (Query cleanups)
 - #151979 (Fix uninitialized UEFI globals in tests)
 - #151992 (Port `#[rustc_hidden_type_of_opaque]` to attribute parser)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 2, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151974 - clundin55:doc-fix, r=jhpratt
2d5e6dc 
Update documentation for `Result::ok()`

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 2, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152002 - JonathanBrouwer:rollup-7XNKruy, r=JonathanBro…
6c4ca5e 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151958 (Add codegen test for SLP vectorization)
 - #151974 (Update documentation for `Result::ok()`)
 - #151975 (Work around rustfmt giving up on a large expression)
 - #151999 (attribute parsing: pass recovery mode to Parser.)
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152002 - JonathanBrouwer:rollup-7XNKruy, r=JonathanBro…
42fc0fb 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151958 (Add codegen test for SLP vectorization)
 - #151974 (Update documentation for `Result::ok()`)
 - #151975 (Work around rustfmt giving up on a large expression)
 - #151999 (attribute parsing: pass recovery mode to Parser.)
rust-bors bot pushed a commit that referenced this pull request Feb 2, 2026
@bors
Auto merge of #152002 - JonathanBrouwer:rollup-7XNKruy, r=JonathanBro…
3ba4b86 
…uwer

Rollup of 4 pull requests

Successful merges:

 - #151958 (Add codegen test for SLP vectorization)
 - #151974 (Update documentation for `Result::ok()`)
 - #151975 (Work around rustfmt giving up on a large expression)
 - #151999 (attribute parsing: pass recovery mode to Parser.)
@jhpratt jhpratt mentioned this pull request Feb 3, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Feb 3, 2026
@bors
Auto merge of #152025 - jhpratt:rollup-Kxb6k3Y, r=jhpratt
46c86ae 
Rollup of 11 pull requests

Successful merges:

 - #151378 (Codegen tests for Arm Cortex-R82)
 - #151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation)
 - #152018 (Move bigint helper tracking issues)
 - #151958 (Add codegen test for SLP vectorization)
 - #151974 (Update documentation for `Result::ok()`)
 - #151975 (Work around rustfmt giving up on a large expression)
 - #151990 (Fix missing unused_variables lint when using a match guard)
 - #151995 (stabilize ptr_as_ref_unchecked)
 - #151999 (attribute parsing: pass recovery mode to Parser.)
 - #152009 (Port rustc_preserve_ub_checks to attr parser)
 - #152022 (rustc-dev-guide subtree update)

Failed merges:

 - #151968 (Remove `HasDepContext` by merging it into `QueryContext`)
@rust-bors rust-bors bot merged commit 7fd1009 into rust-lang:main Feb 3, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 3, 2026
rust-timer added a commit that referenced this pull request Feb 3, 2026
@rust-timer
Unrolled build for #151974
9121ebd 
Rollup merge of #151974 - clundin55:doc-fix, r=jhpratt

Update documentation for `Result::ok()`

The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Feb 4, 2026
@bors
Auto merge of #152025 - jhpratt:rollup-Kxb6k3Y, r=jhpratt
b72d73f 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#151378 (Codegen tests for Arm Cortex-R82)
 - rust-lang/rust#151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation)
 - rust-lang/rust#152018 (Move bigint helper tracking issues)
 - rust-lang/rust#151958 (Add codegen test for SLP vectorization)
 - rust-lang/rust#151974 (Update documentation for `Result::ok()`)
 - rust-lang/rust#151975 (Work around rustfmt giving up on a large expression)
 - rust-lang/rust#151990 (Fix missing unused_variables lint when using a match guard)
 - rust-lang/rust#151995 (stabilize ptr_as_ref_unchecked)
 - rust-lang/rust#151999 (attribute parsing: pass recovery mode to Parser.)
 - rust-lang/rust#152009 (Port rustc_preserve_ub_checks to attr parser)
 - rust-lang/rust#152022 (rustc-dev-guide subtree update)

Failed merges:

 - rust-lang/rust#151968 (Remove `HasDepContext` by merging it into `QueryContext`)
github-actions bot pushed a commit to rust-lang/stdarch that referenced this pull request Feb 5, 2026
@bors
Auto merge of #152025 - jhpratt:rollup-Kxb6k3Y, r=jhpratt
32b13c8 
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#151378 (Codegen tests for Arm Cortex-R82)
 - rust-lang/rust#151936 (Move the `fingerprint_style` special case into `DepKindVTable` creation)
 - rust-lang/rust#152018 (Move bigint helper tracking issues)
 - rust-lang/rust#151958 (Add codegen test for SLP vectorization)
 - rust-lang/rust#151974 (Update documentation for `Result::ok()`)
 - rust-lang/rust#151975 (Work around rustfmt giving up on a large expression)
 - rust-lang/rust#151990 (Fix missing unused_variables lint when using a match guard)
 - rust-lang/rust#151995 (stabilize ptr_as_ref_unchecked)
 - rust-lang/rust#151999 (attribute parsing: pass recovery mode to Parser.)
 - rust-lang/rust#152009 (Port rustc_preserve_ub_checks to attr parser)
 - rust-lang/rust#152022 (rustc-dev-guide subtree update)

Failed merges:

 - rust-lang/rust#151968 (Remove `HasDepContext` by merging it into `QueryContext`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jhpratt jhpratt

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@clundin55 @rustbot @jhpratt @joboet