Rollup of 4 pull requests #152002
Closed
Rollup of 4 pull requests #152002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
Co-authored-by: Nikita Popov <github@npopov.com>
…-test, r=jieyouxu Add codegen test for SLP vectorization close: rust-lang#142519 This PR adds a codegen regression test for rust-lang#142519. A regression in LLVM to fail to auto-vectorize, leading to significant performance loss. The SLP vectorizer correctly groups the 4-byte operations into <4 x i8> vectors. The loop state is maintained in SIMD registers (phi <4 x i8>). The test remains robust across architectures (AArch64 vs x86_64) by allowing flexible store types (i32 or <4 x i8>).
Update documentation for `Result::ok()` The term of "discard" is misleading. An error is not discarded but converted to an `Option::None`.
Work around rustfmt giving up on a large expression - rust-lang/rustfmt#3863 --- In some cases, if rustfmt sees a string literal that is too long for it to comfortably format, it will give up on formatting the entire enclosing expression. For complex builder expressions, that will prevent auto-formatting for frustratingly large sections of code. This PR works around a particular occurrence of that phenomenon in `compiler/rustc_interface/src/util.rs`, by splitting a single error message string across multiple lines. This allows rustfmt to successfully auto-format the entire enclosing expression, which is dozens of lines long. There should be no change to compiler behaviour.
…nBrouwer attribute parsing: pass recovery mode to Parser. Fixes rust-lang#151996
rustbot
added
A-attributes
Contributor
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
bot
added
S-waiting-on-review
Contributor
|
💔 Test for 6c4ca5e failed: CI. Failed job:
|
Contributor
Author
|
@bors retry |
rust-bors
bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 8e39986 with merge 42fc0fb... Workflow: https://github.com/rust-lang/rust/actions/runs/21607825908 |
Contributor
Author
|
@bors yield |
Contributor
|
Auto build cancelled. Cancelled workflows: The next pull request likely to be tested is #152002. |
Contributor
|
⌛ Testing commit 8e39986 with merge 3ba4b86... Workflow: https://github.com/rust-lang/rust/actions/runs/21607878122 |
Contributor
Author
|
@bors r- retry |
rust-bors
bot
added
the
S-waiting-on-author
Contributor
|
Commit 8e39986 has been unapproved. Auto build cancelled due to unapproval. Cancelled workflows: |
rust-bors
bot
removed
the
S-waiting-on-bors
rustbot
removed
the
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Result::ok()#151974 (Update documentation forResult::ok())r? @ghost
Create a similar rollup