mGCA: improve ogca diagnostic message #152952
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 25, 2026
Merged
Conversation
Collaborator
|
HIR ty lowering was modified cc @fmease |
rustbot
added
S-waiting-on-review
Collaborator
|
|
BoxyUwU
reviewed
Feb 24, 2026
Comment on lines
+423
to
+427
| pub(crate) is_ogca: bool, | ||
| #[help( | ||
| "consider factoring the expression into a `type const` item and use it as the const argument instead" | ||
| )] | ||
| pub(crate) help_ogca: bool, |
Member
There was a problem hiding this comment.
does merging these two fields not work?
Contributor
Author
There was a problem hiding this comment.
no, fluent parsing reqire item inside structure, and when there is #[help] macro associated with it, it doesn't recognize it as argument anymore and give ICE as it cant find arg
Member
|
thx for working on this |
Member
|
@rustbot author |
rustbot
removed
the
S-waiting-on-review
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rustbot
added
the
S-waiting-on-author
Member
|
@bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 25, 2026
Rollup of 12 pull requests Successful merges: - #149169 (ptr::replace: make calls on ZST null ptr not UB) - #150562 (Fix doc link used in suggestion for pinning self) - #152418 (`BTreeMap::merge` optimized) - #152679 (rustc_expand: improve diagnostics for non-repeatable metavars) - #152952 (mGCA: improve ogca diagnostic message ) - #152977 (Fix relative path handling for --extern-html-root-url) - #153017 (Implement debuginfo for unsafe binder types) - #152868 (delete some very old trivial `Box` tests) - #152922 (rustc_public: Make fields that shouldn't be exposed visible only in `rustc_public`) - #153032 (Fix attribute parser and kind names.) - #153051 (Migration of `LintDiagnostic` - part 3) - #153060 (Give a better error when updating a submodule fails)
rust-timer
added a commit
that referenced
this pull request
Feb 25, 2026
Rollup merge of #152952 - zedddie:improve-diag, r=BoxyUwU mGCA: improve ogca diagnostic message r? BoxyUwU
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? BoxyUwU