Rollup of 12 pull requests#153074
Merged
rust-bors[bot] merged 37 commits intorust-lang:mainfrom Feb 25, 2026
Merged
Conversation
Co-authored-by: Michael Howell <michael@notriddle.com>
Co-authored-by: Esteban Küber <esteban@kuber.com.ar> Signed-off-by: Usman Akinyemi <usmanakinyemi202@gmail.com>
…o BTreeMap::append)
…s on bulk inserting other_keys into self map, and inlined with_next() insertion on conflicts from Cursor*
For the attribute `FooBar` the parser is generally called `FooBarParser` and the kind is called `AttributeKind::FooBar`. This commit renames some cases that don't match that pattern. The most common cases: - Adding `Rustc` to the front of the parser name for a `rustc_*` attribute. - Adding `Parser` to the end of a parser name. - Slight word variations, e.g. `Deprecation` instead of `Deprecated`, `Pointer` instead of `Ptr`, `Stability` instead of `Stable`.
Previously this would sometimes just say "unexpected output ``", which was extremely unhelpful. The actual issue was that I had a `.jj` directory but not a `.git` directory, so it couldn't run `git submodule update.`
…ark-Simulacrum ptr::replace: make calls on ZST null ptr not UB See rust-lang#138351 for context. We made `ptr::read` and `ptr::write` not UB on ZST null pointers. This does the same with `ptr::replace`. Since we're just adding a branch on a constant, this should come at no runtime cost.
Fix doc link used in suggestion for pinning self Fixes rust-lang#147901 The old suggestion linked to a documentation page that [no longer exists](https://rust-lang.github.io/async-book/04_pinning/01_chapter.html#pinning-in-practice). Presumably, [this](https://rust-lang.github.io/async-book/part-reference/pinning.html) is the better place to link to now
…, r=Mark-Simulacrum `BTreeMap::merge` optimized This is an optimized version of rust-lang#151981. See [ACP](rust-lang/libs-team#739 (comment)) for more information on `BTreeMap::merge` does. CC @programmerjake. Let me know what you think of how I'm using `CursorMut` and `IntoIter` here and whether the unsafe code here looks good. I decided to use `ptr::read()` and `ptr::write()` to grab the value from `CursorMut` as `V` than `&mut V`, use it within the `conflict` function, and overwrite the content of conflicting key afterward. I know this needs some polishing, especially with refactoring some redundant looking code in a nicer way, some of which could probably just be public API methods for `CursorMut`. It does pass all the tests that I currently have for `BTreeMap::merge` (inspired from `BTreeMap::append`) though, so that's good.
…le, r=estebank rustc_expand: improve diagnostics for non-repeatable metavars Fix rust-lang#47452.
mGCA: improve ogca diagnostic message r? BoxyUwU
rustbot
added
T-libs
Member
Author
|
@bors r+ rollup=never p=5 |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
merged-by-bors
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 11ad63a (parent) -> 58745ca (this PR) Test differencesShow 311 test diffsStage 1
Stage 2
Additionally, 227 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 58745ca3b05afa82bd5720dd05f3854e674700e0 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: 11ad63a942 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Feb 25, 2026
Collaborator
|
Finished benchmarking commit (58745ca): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.3%, secondary -3.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.6%, secondary 1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 482.035s -> 478.569s (-0.72%) |
This was referenced Feb 25, 2026
Member
|
Started perf. builds on:
(Damn, too soon again 🤦 Will re-queue once the artifacts are ready). |
Contributor
rustbot
added
the
perf-regression-triaged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
BTreeMap::mergeoptimized #152418 (BTreeMap::mergeoptimized)Boxtests #152868 (delete some very old trivialBoxtests)rustc_public#152922 (rustc_public: Make fields that shouldn't be exposed visible only inrustc_public)LintDiagnostic- part 3 #153051 (Migration ofLintDiagnostic- part 3)r? @ghost
Create a similar rollup