Remove rustc_feedable_queries and define_feedable macros.#153009
Remove rustc_feedable_queries and define_feedable macros.#153009rust-bors[bot] merged 1 commit intorust-lang:mainfrom
rustc_feedable_queries and define_feedable macros.#153009Conversation
rustbot
added
A-query-system
|
|
|
The first commit (not tracking modifier idents) breaks rust-analyzer integration for hovering/clicking on modifier names. The second commit (removing |
This comment has been minimized.
This comment has been minimized.
I have some follow-ups that remove the |
`rustc_queries!` produces two macros: `rustc_with_all_queries` and `rustc_feedable_queries`. The latter is similar to the former but only includes feedable queries. But feedable queries don't need a separate mechanism because we can identify feedable queries within `define_callbacks!` by just looking for the `feedable` modifier. (That's what we do with every modifier other than `feedable`.) This commit removes the special handling and treats feedable queries like everything else. Note that this commit exposes and fixes a latent doc bug. The doc comment for query `explicit_predicates_of` links to `Self::predicates_of`. `explicit_predicates_of` is a feedable query but `predicates_of` is not, so for `TyCtxtFeed` this link is invalid. This wasn't manifesting because `TyCtxtFeed` wasn't getting doc comments attached. It now is, so I changed the link to `TyCtxt::predicates_of`.
nnethercote
force-pushed
the
rm-define_feedable
branch
from
45f6a0a to
8ac769f
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
I have removed the first commit. And I fixed the doc failure, which turned out to be caused by a latent bug; details in the commit message. |
|
Thanks, this is much better than my impl @bors r+ |
rust-bors
bot
added
S-waiting-on-bors
…oli-obk Remove `rustc_feedable_queries` and `define_feedable` macros. The can be folded into `rustc_with_all_queries` and `define_callbacks`. Details in individual commits. r? @oli-obk
…oli-obk Remove `rustc_feedable_queries` and `define_feedable` macros. The can be folded into `rustc_with_all_queries` and `define_callbacks`. Details in individual commits. r? @oli-obk
…uwer Rollup of 15 pull requests Successful merges: - #152176 (Neon fast path for str::contains) - #152657 (std: move `exit` out of PAL) - #152841 (Streamline `QueryVTableUnerased` into `GetQueryVTable`) - #152845 (Skip `tidy` in PR CI jobs not dedicated to running `tidy`) - #152897 (Add optional json logging) - #153009 (Remove `rustc_feedable_queries` and `define_feedable` macros.) - #151558 (Port diagnostic attributes) - #152492 (mGCA: Enforce WF element types for array valtrees) - #152888 (Fix async drop glue MIR bug) - #152988 (Port `#[register_tool]` to the new attribute system) - #153018 (`unused_must_use` lint improvements) - #153023 (Update books) - #153033 (Clarify how "ensure" queries check whether they can skip execution) - #153043 (fix error on missing value for -C flags) - #153045 (rustc-dev-guide subtree update) Failed merges: - #153032 (Fix attribute parser and kind names.)
5 participants
The can be folded into
rustc_with_all_queriesanddefine_callbacks. Details in individual commits.r? @oli-obk