-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
making raw source display better #16066
Conversation
What does the page look like once you start typing in the search field? Does it still look correct? Do you have a live version of this somewhere? |
@kballard: Unfortunately, I can't build Rust tonight. I've only tested these changes by editing the css via Firefox's inspect element utility. Unfortunately doing this at all (even if I just inject an empty style tag) seems to break the search feature completely. So, inconclusive for now, I'm afraid. I can do a build in the morning, though. Is the output of docs completely statically hostable? If so I can host the build, too. |
@gankro AFAIK the output of docs is statically hostable. I haven't actually experimented with that myself though, but it's supposed to work over |
@kballard: great, I should hopefully have it up by noon tomorrow. |
Build available here: http://cg.scs.carleton.ca/~abeinges/doc/ Relevant file: http://cg.scs.carleton.ca/~abeinges/doc/src/core/home2bak/abeinges/rust/src/libcore/iter.rs.html Everything seems fine |
Can you copy the description of the PR into the commit message as well? The commit message is often looked at more than the PR message (for historical purposes) |
* Make the code fill up the full width of the page (no massive whitespace on the left) * Move the code down to make it not intersect the logo * Set a min-width and remove the max-width so that the code doesn't scroll internally, but instead scrolls the page, meaning horizontal scroll bars are always available * Set overflow to actually overflow, just to be sure Fixes rust-lang#15891
@alexcrichton done |
LGTM |
When added in 7669f04 / rust-lang#16066, the page itself was set to scroll. Now it's set so that the `example-wrap` is scrolling inside the page, so the overflow setting for the content is irrelevant.
…-overflow, r=GuillaumeGomez rustdoc: remove redundant CSS `.source .content { overflow: visible }` When added in 7669f04 / rust-lang#16066, the page itself was set to scroll. Now it's set so that the `example-wrap` is scrolling inside the page, so the overflow setting for the content is irrelevant.
fix: auto remove unnecessary braces after remove unused imports before ![before](https://github.com/rust-lang/rust-analyzer/assets/71162630/8d44f955-f84f-4a92-b13f-5a2dee2ded36) after ![after](https://github.com/rust-lang/rust-analyzer/assets/71162630/1eab23c8-39bd-4711-97c1-d483ce400a18)
Summary of changes:
Fixes #15891