trans: use types from argument patterns instead of the function signature. #18458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
free-region-args
branch
from
774d2be to
9c258ea
Compare
|
@eddyb I was afraid of this problem. You may be hitting the error that a ref binding's type is |
|
The true fix I think is that we ought to have two ids for a binding, one to use for the type of value it is matching against (the pattern id) and one to use for the type of the value that is produced by the binding (the binding id). |
eddyb
force-pushed
the
free-region-args
branch
2 times, most recently
from
d63a561 to
73d00bd
Compare
…ture. This fixes ICEs caused by late-bound lifetimes ending up in argument datum types and being used in cleanup - user Drop impl's would then fail to monomorphize if the type was used to look up the impl of a method call - which happens in trans now, I presume for multidispatch.
eddyb
force-pushed
the
free-region-args
branch
from
73d00bd to
96ba514
Compare
bors
added a commit
that referenced
this pull request
Oct 31, 2014
This fixes ICEs caused by late-bound lifetimes ending up in argument datum types and being used in cleanup - user Drop impl's would then fail to monomorphize if the type was used to look up the impl of a method call - which happens in trans now, I presume for multidispatch.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Dec 11, 2024
feat: Add diagnostic fix to remove unnecessary wrapper in type mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes ICEs caused by late-bound lifetimes ending up in argument
datum types and being used in cleanup - user Drop impl's would then
fail to monomorphize if the type was used to look up the impl of a
method call - which happens in trans now, I presume for multidispatch.