Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: Use UFCS in the expansion of #[deriving(PartialOrd)] #18755

Closed
wants to merge 2 commits into from

Conversation

japaric
Copy link
Member

@japaric japaric commented Nov 7, 2014

Closes #18738
cc #15689

r? @alexcrichton
cc @cmr

let new = {
let other_f = match other_fs {
[ref o_f] => o_f,
_ => cx.span_bug(span, "not exactly 2 arguments in `deriving(Ord)`"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Ord/PartialOrd/

@japaric
Copy link
Member Author

japaric commented Nov 8, 2014

Addressed @huonw comment. re-r?

bors added a commit that referenced this pull request Nov 9, 2014
@bors bors closed this Nov 9, 2014
japaric pushed a commit to japaric/rust that referenced this pull request Dec 7, 2014
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 9, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Jan 7, 2025
fix: Fix metrics workflow using the wrong download-artifact version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PartialOrd derving broken for slices
4 participants