Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax: use UFCS in the expansion of #[deriving(Ord)] #19598

Merged
merged 1 commit into from
Dec 9, 2014

Conversation

japaric
Copy link
Member

@japaric japaric commented Dec 6, 2014

@brendanzab
Copy link
Member

Whaaaaat. UFCS! It is here?! :o

Anyway, you need to clean your trailing whitespace :)

@japaric
Copy link
Member Author

japaric commented Dec 6, 2014

@bjz Done

@@ -95,6 +102,20 @@ pub fn cs_cmp(cx: &mut ExtCtxt, span: Span,
// __test
// }

let new = {
let other_f = match other_fs {
[ref o_f] => o_f,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation... sorry!

@japaric
Copy link
Member Author

japaric commented Dec 6, 2014

@bjz Added indentation

@japaric
Copy link
Member Author

japaric commented Dec 7, 2014

@bjz Had to rebase after a merge conflict in a comment. re-r?

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Dec 9, 2014
@bors bors merged commit 8dcdd1e into rust-lang:master Dec 9, 2014
@japaric japaric deleted the ord branch December 16, 2014 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants