-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Added as
and move
keywords to Vim syntax file
#18782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
Move has been a keyword for a long time, but it was removed in 0.6, and kept reserved. Then it was recently brought back.= |
@steveklabnik, didn't know that. Anyway, previously it wasn't used so its missing highlighting wasn't a problem. |
@@ -23,7 +23,7 @@ syn keyword rustKeyword box nextgroup=rustBoxPlacement skipwhite skipempty | |||
syn keyword rustKeyword continue | |||
syn keyword rustKeyword extern nextgroup=rustExternCrate,rustObsoleteExternMod skipwhite skipempty | |||
syn keyword rustKeyword fn nextgroup=rustFuncName skipwhite skipempty | |||
syn keyword rustKeyword for in if impl let | |||
syn keyword rustKeyword for in if impl let as move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as
is already a rustOperator
(see line 17), so marking it as a keyword as well is unnecessary. as
is already highlighted in Vim today.
Could you squeeze in an update to |
@P1start, strange, it is not highlighted for me. Probably my color scheme problems, I'll revert it. |
a3d8987
to
3961eae
Compare
Ah, I see that since |
`as` (already for a long time) and `move` (which was only added recently, AFAIK) are not marked as keywords in Vim syntax file, so they are not highlighted as keywords in Rust sources. This PR fixes this.
@cuviper, no, I didn't. Either would be fine for me, as long as they are highlighted :) |
as
(already for a long time) andmove
(which was only added recently, AFAIK) are not marked as keywords in Vim syntax file, so they are not highlighted as keywords in Rust sources. This PR fixes this.