vim: move 'move' to rustStorage #18789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. |
|
#18782 seems to do this as well, although it adds |
bors
added a commit
that referenced
this pull request
Nov 10, 2014
It used to be in `rustKeyword`, but commit 5c75f21 removed it. It was reintroduced as a keyword in 0.12.0 to indicate by-value closures, and I think `rustStorage` highlighting makes sense for that purpose.
|
Ah yes, I forgot about that, thanks @P1start! @cuviper are you ok with it just as a keyword for now (instead of the storage class)? |
|
It's OK, but I think the storage class is better. :) I'll ask @netvl on the other issue. |
cuviper
changed the title
|
Ok, @netvl doesn't mind, so I've now rebased this as a change to his placement of |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 7, 2025
fix: Fix invalid `-O` flag used by cfg discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It used to be in
rustKeyword, until commit 5c75f21 removed it, and then #18782 restored it again. However, this is now a closure modifier, and I think moving it torustStorageis more appropriate to highlight it similarly tomut,ref, and the&sigil.