Generalize MacExpr / MacPat / MacItems #18814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kmcallister |
|
I don't have review privs on rust-lang/rust, but I added some comments. |
|
The blak lines are not present in the other Mac* so I didn't put them in MacGeneral for consistency, but I can add the blank lines |
|
This looks like an alternate approach to #19019 . Would anyone like to mediate between the two? |
|
@gamazeps any chance you can address the comments on this patch? Do you want one of us to take it and fix the minor issues? also, is this still needed? |
|
r? @kmcallister (just making sure the PR has an assignee, I think you have review privileges now?) |
|
This doesn't really resolve #17637; it should also remove the special-purpose types. The patch has some other problems; I'm working on a revived PR. |
kmcallister
added a commit
to kmcallister/rust
that referenced
this pull request
Feb 27, 2015
MacEager is a MacResult implementation for the common case where you've already built each form of AST that you might return. Fixes rust-lang#17637. Based on rust-lang#18814. This is a [breaking-change] for syntax extensions: * MacExpr::new becomes MacEager::expr. * MacPat::new becomes MacEager::pat. * MacItems::new becomes MacEager::items. It takes a SmallVector directly, not an iterator.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 28, 2015
MacEager is a MacResult implementation for the common case where you've already built each form of AST that you might return. Fixes rust-lang#17637. Based on rust-lang#18814. This is a [breaking-change] for syntax extensions: * MacExpr::new becomes MacEager::expr. * MacPat::new becomes MacEager::pat. * MacItems::new becomes MacEager::items. It takes a SmallVector directly, not an iterator. r? @sfackler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be a bit clumsy ...
Closes #17637