creating convenience types for make_def, make_stmt, make_methods in MacResult #19019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unifying with MacroDefiner
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. |
|
Sorry that this has been sitting so long! pcwalton is probably swamped at the moment, I'll try to get someone more familiar with libsyntax to peek at this. |
|
Looks like this would conflict with another PR, #18814 . Not sure which to prefer. @kmcallister, care to weigh in? |
|
From IRC right now: |
|
Closing in favor of #18814. Thank you for this, though! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jan 27, 2025
Explicitly add buildfiles when constructing ProjectFolders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting writing a plugin and noticed that there were convenience types for a few of the methods in the
MacResulttrait but not for all of them. So I added some formake_stmt,make_methods, andmake_def. For the last one, I noticed that essentially the same struct existed in macro_rules, so I removed it.