Document remaining attributes and macros #21091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
The plugins guide says a little about the |
|
Should I just put that for now, then? |
|
I have a feeling there's been additions to our set of macros & attributes since #6444, but I am unsure. |
|
That's possible. Where's the definitive list? |
steveklabnik
force-pushed
the
add_attribute_docs
branch
from
52cf714 to
d69ac86
Compare
|
I think this is good enough to ship now. If there is anything else I missed, it'll get caught in the reference work. |
| @@ -2041,6 +2050,8 @@ type int8_t = i8; | |||
| item](#language-items) for more details. | |||
| - `test` - indicates that this function is a test function, to only be compiled | |||
| in case of `--test`. | |||
| - `should_fail` - indicates that this test function should panic, inverting the success condition. | |||
| - `cold` - The function is unlikely to be executed, so optimize it differently. | |||
There was a problem hiding this comment.
"so optimize it and calls to it", maybe? (IME, the main use is making the compiler rearrange branches to preference the ones that don't have #[cold] functions.)
|
(r=me) |
steveklabnik
force-pushed
the
add_attribute_docs
branch
from
d69ac86 to
4a6af11
Compare
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Jan 22, 2015
…huonw Fixes rust-lang#6444 I need some help with the macro docs here, as I couldn't figure it out. @kmcallister @eddyb or someone else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6444
I need some help with the macro docs here, as I couldn't figure it out. @kmcallister @eddyb or someone else?