Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine wording of Thread::panicking #21325

Merged
merged 1 commit into from
Jan 23, 2015
Merged

Conversation

nagisa
Copy link
Member

@nagisa nagisa commented Jan 17, 2015

Previous wording wasn’t clear about its actual behaviour. It could be
interpreted as answering either:

  • Can current thread panic?
  • Is current thread unwinding because of panic?

r? @steveklabnik

Verified

This commit was signed with the committer’s verified signature. The key has expired.
6543 6543
Previous wording wasn’t clear about its actual behaviour. It could be
interpreted as answering either:

* Can current thread panic?
* Is current thread unwinding because of panic?
@steveklabnik
Copy link
Member

@bors: r+ rollup 618cf5f

@bors
Copy link
Contributor

bors commented Jan 22, 2015

🙀 You have the wrong number! Please try again with 618cf5f.

@steveklabnik
Copy link
Member

@bors: r+ 618cf5f rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 22, 2015

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…bnik

Previous wording wasn’t clear about its actual behaviour. It could be
interpreted as answering either:

* Can current thread panic?
* Is current thread unwinding because of panic?

r? @steveklabnik
bors added a commit that referenced this pull request Jan 23, 2015

Verified

This commit was signed with the committer’s verified signature.
- Successful merges: #21056, #21091, #21217, #21325, #21373, #21450, #21471, #21472, #21477, #21479, #21484, #21496, #21500, #21516, #21517
- Failed merges:
@bors bors merged commit 618cf5f into rust-lang:master Jan 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants