Update licenseck.py to not check for copyright #21489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson |
|
|
||
| # Xfail check | ||
| firstlineish = contents[:100] | ||
| if firstlineish.find("ignore-license") != -1: | ||
| if "ignore-license" in firstlineish: | ||
| return True | ||
|
|
||
| # License check | ||
| boilerplate = contents[:500] |
There was a problem hiding this comment.
If the copyright lines do get removed, 500 can probably be decreased to 350, but doing so in this PR causes a failing build since the copyright lines are currently still there.
|
Closing as per the official response regarding copyright notices in #21481. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to be merged alongside #21481 in order to prevent
licenseck.pyfrom looking for the copyright notices at the top of each file. Some other changes are included to make the code more Pythonic as well.