-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove copyright lines #21481
remove copyright lines #21481
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
Maybe not, but it wasn't a big deal to |
So beautiful. ;_; |
#!/usr/bin/env python | ||
# | ||
# Copyright 2014 The Rust Project Developers. See the COPYRIGHT | ||
# file at the top-level directory of this distribution and at | ||
# http://rust-lang.org/COPYRIGHT. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops. There are a few more of these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I went back in and manually fixed all of them. :(
Never mind; for some reason, I completely forgot that PRs can be merged simultaneously without breaking Travis. Resubmitted my fix as a PR against this repository. |
@iKevinY you can also submit a PR to my PR |
@steveklabnik Heh, I did that initially but then figured it was an unorthodox way of doing things. I've reopened my PR on your fork. |
Why are these lines being removed? It's what the Apache license explicitly says to add to each source file |
You can't remove them. They are indeed legally near-useless; however, several licenses (which, I believe, include the ones Rust is using) require that they be preserved if they are present. E.g Apache License 2.0, section 4 c): "You must retain, in the Source form of any Derivative Works that You distribute, all copyright, patent, trademark, and attribution notices from the Source form of the Work, excluding those notices that do not pertain to any part of the Derivative Works" So unless you get the permission of all copyright holders, I'm afraid you are stuck with them :-( Gerv |
That sucks :( Thanks for clarifying! |
Yeah, sorry :-( |
Should we at least stop putting it in new files? >__> |
@brson has stated we can at least not increment any of the dates. |
EDIT: I didn't mean to press send on this, disregard |
Yes, you could certainly not bother to increment the dates, and you could probably remove the "See the COPYRIGHT file" text if you thought it was unnecessary. But consistency is useful. That's the reason why it's probably not a good idea to stop putting a copyright line in the header on new files. The standard Apache boilerplate has a copyright line; if you want friction-free "Ah, it's Apache, I understand that" use, it's best to use the standard boilerplate. |
If these are useless, as @brson says #9070 (comment), we should just remove them.
Fixes #9070.