Add a lint for writing #[feature] for stable features, warn by default...
#21958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult. The 'stable_features' lint helps people progress from unstable to stable Rust by telling them when they no longer need a `feature` attribute because upstream Rust has declared it stable. This compares to the existing 'unstable_features', which is used to implement feature staging, and triggers on *any* use of `#[feature]`.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @alexcrichton cc @aturon |
|
This seems to give me errors like: IIRC all lints are set to Deny on stage2 builds. I think. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 6, 2015
.... The 'stable_features' lint helps people progress from unstable to stable Rust by telling them when they no longer need a `feature` attribute because upstream Rust has declared it stable. This compares to the existing 'unstable_features' lint, which is used to implement feature staging, and triggers on *any* use of `#[feature]`.
|
⌛ Testing commit 456d23e with merge a83f5f9... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors: retry |
|
@Manishearth huh, the unused features lint didn't change much here. maybe a problem in other rollup patches. i'll test this again locally. |
|
Nah, I found the issue :) |
|
⌛ Testing commit 456d23e with merge aca22ed... |
|
💔 Test failed - auto-linux-64-x-android-t |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 1, 2016
…notes_version_stabilized, r=brson stable features lint warning mentions version stabilized To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. Fixes rust-lang#33394.  r? @brson (tagging Brian because he [wrote](rust-lang#21958) the lint)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....
The 'stable_features' lint helps people progress from unstable to
stable Rust by telling them when they no longer need a
featureattribute because upstream Rust has declared it stable.
This compares to the existing 'unstable_features' lint, which is used
to implement feature staging, and triggers on any use
of
#[feature].