Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stable features lint warning mentions version stabilized #33973

Conversation

zackmdavis
Copy link
Member

@zackmdavis zackmdavis commented May 30, 2016

To accomplish this, we alter the checks in rustc::middle::stability to
use the StabilityLevel defined in syntax::attr (which includes the
version in which the feature was stabilized) rather than the local
StabilityLevel in the same module, and make the
declared_stable_lang_features field of
syntax::feature_gate::Features hold a Vec of feature-name, span
tuples (in analogy to the declared_lib_features field) rather than
just spans.

Fixes #33394.

stable_features_version_lint_before_and_after

r? @brson (tagging Brian because he wrote the lint)

To accomplish this, we alter the checks in `rustc::middle::stability` to
use the `StabilityLevel` defined in `syntax::attr` (which includes the
version in which the feature was stabilized) rather than the local
`StabilityLevel` in the same module, and make the
`declared_stable_lang_features` field of
`syntax::feature_gate::Features` hold a Vec of feature-name, span
tuples (in analogy to the `declared_lib_features` field) rather than
just spans.

This is in the matter of issue rust-lang#33394.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Aatch
Copy link
Contributor

Aatch commented May 31, 2016

I slightly edited your issue to read "Fixes #33394", so Github will close the relevant issue automatically.

@brson
Copy link
Contributor

brson commented May 31, 2016

@bors r+

@bors
Copy link
Contributor

bors commented May 31, 2016

📌 Commit 06c9e0f has been approved by brson

@bors
Copy link
Contributor

bors commented May 31, 2016

⌛ Testing commit 06c9e0f with merge 8bb86da...

@bors
Copy link
Contributor

bors commented May 31, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@alexcrichton
Copy link
Member

@bors: retry

On Tue, May 31, 2016 at 3:50 PM, bors notifications@github.com wrote:

💔 Test failed - auto-linux-64-opt-rustbuild
http://buildbot.rust-lang.org/builders/auto-linux-64-opt-rustbuild/builds/1300


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#33973 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD95Nng13NU_lwPSh2yMOwqFfH22pjSks5qHLscgaJpZM4IqEB6
.

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 1, 2016
…notes_version_stabilized, r=brson

stable features lint warning mentions version stabilized

To accomplish this, we alter the checks in `rustc::middle::stability` to
use the `StabilityLevel` defined in `syntax::attr` (which includes the
version in which the feature was stabilized) rather than the local
`StabilityLevel` in the same module, and make the
`declared_stable_lang_features` field of
`syntax::feature_gate::Features` hold a Vec of feature-name, span
tuples (in analogy to the `declared_lib_features` field) rather than
just spans.

Fixes rust-lang#33394.

![stable_features_version_lint_before_and_after](https://cloud.githubusercontent.com/assets/1076988/15659237/5d952a3a-267c-11e6-9181-c9e612eefd7d.png)

r? @brson (tagging Brian because he [wrote](rust-lang#21958) the lint)
bors added a commit that referenced this pull request Jun 1, 2016
Rollup of 11 pull requests

- Successful merges: #33385, #33606, #33841, #33892, #33896, #33915, #33921, #33967, #33970, #33973, #33977
- Failed merges:
@bors bors merged commit 06c9e0f into rust-lang:master Jun 1, 2016
@zackmdavis zackmdavis deleted the stable_features_warning_notes_version_stabilized branch October 18, 2016 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants