Rollup of 11 pull requests #34004
Merged
Rollup of 11 pull requests #34004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to talk about that here
As stated in rust-lang#31007 the copyright notice should reflect the year of original publication, thus avoiding useless updates every year.
…cking. This was already rejected during expansion. Encountering malformed LHS or RHS during expansion is now considered a bug.
Implementing the Write trait for Cursors over slices is so light-weight that under some circumstances multiple writes can be fused into a single instruction. In general I think inlining these functions is a good idea because most of the code can be constant-folded and copy-propagated away. Closes issue rust-lang#33916.
…h` returns `Err(true)` In 1a374b8, (pr rust-lang#33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that `record_def` was called in all cases, which lead to an ICE in [1]. This change restores the original `else` case, but keeps the changes that were committed in 1a374b8. This commit fixes issue rust-lang#33293. [1] `rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_`
To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. This is in the matter of issue rust-lang#33394.
Mention initial year of publication only for the documentation copyright I have corrected the "copyright expiration year" that was still 2015 in the documentation copyright notice. According to rust-lang#31007 it seems that we could go one step further and simplify the copyright notice to only mention the year of original publication ("Copyright © 2011" in this case). Let me know if you would prefer this copyright notice to only mention the year of original publication (please make sure that it is really 2011 as stated in the current version of the documentation, and not 2010 like Rust's code) and I'll make the simplification.
doc: format! may or may not handle streams in future No need to talk about that here
…kfelix Reject a LHS formed of a single sequence TT during `macro_rules!` checking. This was already rejected during expansion. Encountering malformed LHS or RHS during expansion is now considered a bug. Follow up to rust-lang#33689. r? @pnkfelix Note: this can break code that defines such macros but does not use them.
…chton core: check pointer equality when comparing byte slices If pointer address and length are the same, it should be the same slice. In experiments, I've seen that this doesn't happen as often in debug builds, but release builds seem to optimize to using a single pointer more often.
make core::str::next_code_point work on arbitrary iterator
…abnik Add new error code tests r? @steveklabnik
Inline simple Cursor write calls Implementing the Write trait for Cursors over slices is so light-weight that under some circumstances multiple writes can be fused into a single instruction. In general I think inlining these functions is a good idea because most of the code can be constant-folded and copy-propagated away. Closes issue rust-lang#33916. r? @alexcrichton
…, r=petrochenkov resolve: record pattern def when `resolve_pattern` returns `Err(true)` I propose a fix for issue rust-lang#33293. In 1a374b8, (pr rust-lang#33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that `record_def` was called in all cases, which lead to an ICE in [1]. This change restores the original `else` case, but keeps the changes that were committed in 1a374b8. [1] `rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_`
normalize types in MIR typeck after erasing regions this fixes the MIR bug @frankmcsherry encountered. r? @eddyb
…notes_version_stabilized, r=brson stable features lint warning mentions version stabilized To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. Fixes rust-lang#33394.  r? @brson (tagging Brian because he [wrote](rust-lang#21958) the lint)
Take the def_map argument to TyCtxt::create_and_enter out of its RefCell.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=20 |
|
📌 Commit 42e593a has been approved by |
|
@bors force |
|
💔 Test failed - auto-win-msvc-32-opt |
|
@bors retry force
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macro_rules!checking. #33841, core: check pointer equality when comparing byte slices #33892, make core::str::next_code_point work on arbitrary iterator #33896, Add new error code tests #33915, Inline simple Cursor write calls #33921, resolve: record pattern def whenresolve_patternreturnsErr(true)#33967, normalize types in MIR typeck after erasing regions #33970, stable features lint warning mentions version stabilized #33973, Take the def_map argument to TyCtxt::create_and_enter out of its RefCell. #33977