-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright year set to initial #31007
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
cc #30665 |
r? @brson |
The relevant section is under in the pdf is "Form of Notice for Visually Perceptible Copies". Based on it, it does look like we should write the year of first publication. 2014 isn't the year of first publication though. It's not even the year Rust was relicensed to MIT/Apache-2.0. Should these maybe say 2010? Are there reasons we should keep these updated? cc @rust-lang/core |
☔ The latest upstream changes (presumably #30958) made this pull request unmergeable. Please resolve the merge conflicts. |
@pra85 Please change the dates to 2010 and I'll r+. Thanks for your patience. |
@brson I have changed the date to 2010 |
Do not merge this PR as is. When you merge some changes into the code base, you have just made a derivative work of the original work (=the parent commit). As pointed out by point 2 of your excerpt, a derivative work needs to have the copyright year of initial publication of the derivative work. This is why you sometimes see aggregate copright notices on files, because different parts of the file were authored in different years. In short this means that for every PR, you need to add to the copyright year of every file you change the current year. Perhaps we can have @bors check/do this automatically. If you think the whole state of the Rust project after a particular commit is a derivative work of its parent commit, then the main copyright file should just have the year of the latest commit. If you think the Rust project consists of many individual works, each with different authorship dates, then the main copyright file should probably say something like © 2010-This year. |
Interesting point.
Though possibly true in a technical sense, we do not believe this to be the case in practice and actively discourage people from updating the copyright year. The advice we've received previously is that the copyright dates in the file headers have little legal weight beyond what is already established in the commit history. Previous discussion. Here's the salient point: "the actual copyright status of the file is unaffected by what it says at the top, so people for whom it's actually important when the copyright expires (i.e. no-one) will have to do more research in any case." By the logic of our previous decisions (which was in the context of file headers and not the blanket copyright notice) I still believe this is a reasonable course of action, but I'll ask around more. |
Certainly true.
I guess this makes sense because we basically grant all rights to everyone.
Yes, please don't take my word (i.e. CS major who took some IP law classes) for it. |
I've reached out to Mozilla's legal staff to get some advice on this issue. I'll post a follow-up comment as soon as I have information to share. |
The response from Mozilla legal was that, while none of these notices are legally required, this PR is correct: if we have a copyright notice, it should reflect the year of original publication. @bors: r+ |
📌 Commit 8c96f37 has been approved by |
@bors: rollup |
According to http://www.copyright.gov/circs/circ01.pdf (See screenshot of relevant section below) , listing the first year of publication in the copyright is enough ![selection_008](https://cloud.githubusercontent.com/assets/829526/12409934/7021c3a6-be95-11e5-8d1a-18f6948571e0.png) The commits d5c8f62 and f979f91 have changed the copyright years This commit reverts back those changes, so that license year is again 2014 (As it was, when this license was first introduced in commit 90ba013 ) -------------------------------------- Edit 1: Added screenshot
As stated in rust-lang#31007 the copyright notice should reflect the year of original publication, thus avoiding useless updates every year.
Mention initial year of publication only for the documentation copyright I have corrected the "copyright expiration year" that was still 2015 in the documentation copyright notice. According to rust-lang#31007 it seems that we could go one step further and simplify the copyright notice to only mention the year of original publication ("Copyright © 2011" in this case). Let me know if you would prefer this copyright notice to only mention the year of original publication (please make sure that it is really 2011 as stated in the current version of the documentation, and not 2010 like Rust's code) and I'll make the simplification.
According to http://www.copyright.gov/circs/circ01.pdf (See screenshot of relevant section below) , listing the first year of publication in the copyright is enough
The commits d5c8f62 and f979f91 have changed the copyright years
This commit reverts back those changes, so that license year is again 2014 (As it was, when this license was first introduced in commit 90ba013 )
Edit 1: Added screenshot