-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update copyright date #30665
Update copyright date #30665
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
AFAIK we change the years only when we actually modify those files (not sure if |
Sorry, I didn't know. LICENSE-MIT and COPYRIGHT files should still be changed I can update this PR to only change those files if that's what you would like. |
@eddyb We don't even consistently update the years when modifying files. As one random example, |
These shouldn't be updated for the sake of being updated Previous discussion: #9070 |
@zachpanz88 If you want to work on this you could add support to src/etc/licenseck.py/src/etc/tidy.py to check the year based on the date of the git last commit. I would be glad to have these updated according to their changes. |
I have updated this PR to only change the @eddyb I can work on updating the files you mentioned above. You would want it to automatically update the comment at the top of the file to match the date at which the file was last updated correct? |
@zachpanz88 The scripts are supposed to check but not actually modify files. Auto-modification functionality would have to be separate. |
@eddyb Okay, so you want the program to check if the copyright date is the same as the last modified date and if not, display a message to the user. |
Specifically those programs should cause make tidy to fail if they don't match, that way people would be forced to not forget. |
This pull request looks good to me with the latest changes |
@bors: r+ rollup |
📌 Commit d5c8f62 has been approved by |
⌛ Testing commit d5c8f62 with merge ebc6ca8... |
💔 Test failed - auto-linux-64-nopt-t |
Not sure how that could have happened |
@zachpanz88 It's spurious, we've seen a lot of these lately. @bors retry |
New copyright date Happy new year!
New copyright date Happy new year!
New copyright date Happy new year!
New copyright date
Happy new year!