Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify scenario where AsciiExt appears to operate on non-ASCII #31401

Merged
merged 1 commit into from
Feb 5, 2016

Conversation

frewsxcv
Copy link
Member

@frewsxcv frewsxcv commented Feb 4, 2016

Fixes #31203

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 4, 2016

r? @steveklabnik

/// results. Consider this example:
///
/// ```
/// # use std::ascii::AsciiExt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showing the imports is considered better nowadays.

@steveklabnik
Copy link
Member

Thanks so much! A few nits, and also, could you wrap this to 80 cols, not 100? libstd uses 80.

@frewsxcv
Copy link
Member Author

frewsxcv commented Feb 4, 2016

Comments have been addressed

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks so much

@bors
Copy link
Collaborator

bors commented Feb 4, 2016

📌 Commit 93d6425 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 4, 2016
bors added a commit that referenced this pull request Feb 4, 2016
@bors bors merged commit 93d6425 into rust-lang:master Feb 5, 2016
@frewsxcv frewsxcv deleted the clarify-ascii branch July 17, 2016 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants