resolve: record pattern def when resolve_pattern returns Err(true)
#33967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h` returns `Err(true)` In 1a374b8, (pr rust-lang#33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that `record_def` was called in all cases, which lead to an ICE in [1]. This change restores the original `else` case, but keeps the changes that were committed in 1a374b8. This commit fixes issue rust-lang#33293. [1] `rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_`
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
N.b. I think that a test case should be added to this PR. This gist shows a suitable piece of code. and the the same time not report: |
dsprenkels
changed the title
resolve_pattern returns Err(true)resolve_pattern returns Err(true)
|
r? @Manishearth |
|
LGTM. |
|
@bors r=petrochenkov |
|
📌 Commit cde0f94 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jun 1, 2016
…, r=petrochenkov resolve: record pattern def when `resolve_pattern` returns `Err(true)` I propose a fix for issue rust-lang#33293. In 1a374b8, (pr rust-lang#33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that `record_def` was called in all cases, which lead to an ICE in [1]. This change restores the original `else` case, but keeps the changes that were committed in 1a374b8. [1] `rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose a fix for issue #33293.
In 1a374b8, (pr #33046) fixed the error reporting of a specific case, but the change that was introduced did not make sure that
record_defwas called in all cases, which lead to an ICE in [1].This change restores the original
elsecase, but keeps the changes that were committed in 1a374b8.[1]
rustc::middle::mem_categorization::MemCategorizationContext::cat_pattern_