Make FRU respect privacy of all struct fields, mentioned or unmentioned. #22144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is RFC 736. Fix rust-lang#21407.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| self.check_field(expr.span, id, | ||
| NamedField(field.ident.node)); | ||
| ty::ty_struct(ctor_id, _) => { | ||
| let all_fields = ty::lookup_struct_fields(self.tcx, ctor_id); |
There was a problem hiding this comment.
Might be worth a comment (maybe with a pointer to the RFC), clarifying that
- The fields that are explicitly mentioned must be public
- The rest must also be public as described in RFC #xyz and issue #xyz
|
r+ modulo comment |
|
@bors: r- |
|
(need to add |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 10, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make FRU respect privacy of all struct fields, mentioned or unmentioned.
This is RFC 736.
Fix #21407.
(Also, partially addresses #6993, but I do not know whether there are other uses of
Identstill outstanding; there are no more references to #6993 present in the code base after this commit.)