-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make FRU respect privacy of all struct fields, mentioned or unmentioned. #22144
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42 changes: 42 additions & 0 deletions
42
src/test/compile-fail/functional-struct-update-respects-privacy.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
// RFC 736 (and Issue 21407): functional struct update should respect privacy. | ||
|
||
// The `foo` module attempts to maintains an invariant that each `S` | ||
// has a unique `u64` id. | ||
use self::foo::S; | ||
mod foo { | ||
use std::cell::{UnsafeCell}; | ||
|
||
static mut count : UnsafeCell<u64> = UnsafeCell { value: 1 }; | ||
|
||
pub struct S { pub a: u8, pub b: String, secret_uid: u64 } | ||
|
||
pub fn make_secrets(a: u8, b: String) -> S { | ||
let val = unsafe { let p = count.get(); let val = *p; *p = val + 1; val }; | ||
println!("creating {}, uid {}", b, val); | ||
S { a: a, b: b, secret_uid: val } | ||
} | ||
|
||
impl Drop for S { | ||
fn drop(&mut self) { | ||
println!("dropping {}, uid {}", self.b, self.secret_uid); | ||
} | ||
} | ||
} | ||
|
||
fn main() { | ||
let s_1 = foo::make_secrets(3, format!("ess one")); | ||
let s_2 = foo::S { b: format!("ess two"), ..s_1 }; // FRU ... | ||
//~^ ERROR field `secret_uid` of struct `foo::S` is private | ||
println!("main forged an S named: {}", s_2.b); | ||
// at end of scope, ... both s_1 *and* s_2 get dropped. Boom! | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth a comment (maybe with a pointer to the RFC), clarifying that