Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstabilise words for now. #22253

Merged
merged 1 commit into from
Feb 17, 2015
Merged

Unstabilise words for now. #22253

merged 1 commit into from
Feb 17, 2015

Conversation

huonw
Copy link
Member

@huonw huonw commented Feb 13, 2015

It is not totally clear if we should just use whitespace, or if the full
unicode word-breaking algorithm is more correct. If there is demand we
can reconsider this decision (and consider the precise algorithm to use
in detail).

cc #15628.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Feb 13, 2015

@huonw Would you mind introducing a separate feature name here (perhaps our first such use of the system??) Unlike the "collections" feature, I could see this feature persisting as unstable for some time. Which makes me realize we need conventions for feature names...

Perhaps str-words?

It is not totally clear if we should just use whitespace, or if the full
unicode word-breaking algorithm is more correct. If there is demand we
can reconsider this decision (and consider the precise algorithm to use
in detail).

cc rust-lang#15628.
@aturon
Copy link
Member

aturon commented Feb 13, 2015

@bors: r+ 3d9528a

@huonw
Copy link
Member Author

huonw commented Feb 13, 2015

@bors rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 13, 2015
It is not totally clear if we should just use whitespace, or if the full
unicode word-breaking algorithm is more correct. If there is demand we
can reconsider this decision (and consider the precise algorithm to use
in detail).

cc rust-lang#15628.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 14, 2015
It is not totally clear if we should just use whitespace, or if the full
unicode word-breaking algorithm is more correct. If there is demand we
can reconsider this decision (and consider the precise algorithm to use
in detail).

cc rust-lang#15628.
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 15, 2015
It is not totally clear if we should just use whitespace, or if the full
unicode word-breaking algorithm is more correct. If there is demand we
can reconsider this decision (and consider the precise algorithm to use
in detail).

cc rust-lang#15628.
Manishearth added a commit to Manishearth/rust that referenced this pull request Feb 17, 2015
It is not totally clear if we should just use whitespace, or if the full
unicode word-breaking algorithm is more correct. If there is demand we
can reconsider this decision (and consider the precise algorithm to use
in detail).

cc rust-lang#15628.
@bors bors merged commit 3d9528a into rust-lang:master Feb 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants