Rollup of 34 pull requests #22352
Closed
Rollup of 34 pull requests #22352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to @dotdash it enables more aggressive optimizations from LLVM
It is not totally clear if we should just use whitespace, or if the full unicode word-breaking algorithm is more correct. If there is demand we can reconsider this decision (and consider the precise algorithm to use in detail). cc rust-lang#15628.
In `std::f32` and `std::f64`: - `MIN_VALUE` → `MIN` - `MAX_VALUE` → `MAX` - `MIN_POS_VALUE` → `MIN_POSITIVE` This matches the corresponding integer constants. [breaking-change]
Also add address of IRC server. Addresses rust-lang#22249.
This partially resolves rust-lang#22243.
This resolves rust-lang#22243, at least for one-letter variable names.
Remove incorrect claim, add example, reformat and re-word. Fixes rust-lang#22266
Rollup merge (373cbab) of PR rust-lang#20723 accidentally reverted a portion of commit 8327bcc which shifted `slicing_syntax` from Active to Accepted.
We use them in some places, but never actually talk about the syntax.
Added a second note about keeping the reference.md list up-to-date to the bottom of the list, since not everyone (including me) reads the big comment at the top of it. :) Ensured that the feature gate list in reference.md is kept in alphabetical order.
if found on the `main()` function. This lets you write tests that live in `compile-fail` but are expected to compile successfully. This is handy when you have many small variations on a theme that you want to keep together, and you are just testing the type checker, not the runtime semantics.
This isn't something we want to guarantee.
Fixes rust-lang#22047 Range<u64> and Range<i64> may be longer than usize::MAX on 32-bit platforms, and thus they cannot fulfill the protocol for ExactSizeIterator. We don't want a nonobvious platform dependency in basic iterator traits, so the trait impl is removed. The logic of this change assumes that usize is at least 32-bit. This is technically a breaking change; note that Range<usize> and Range<isize> are always ExactSizeIterators. [breaking-change]
rustc --version says ``` rustc 1.0.0-dev (d0e82a6 2015-02-05) (built 2015-02-11) ```
…omatsakis This isn't something we want to guarantee. r? @nikomatsakis
…=alexcrichton Fixes rust-lang#22047 `Range<u64>` and `Range<i64>` may be longer than usize::MAX on 32-bit platforms, and thus they cannot fulfill the protocol for ExactSizeIterator. We don't want a nonobvious platform dependency in basic iterator traits, so the trait impl is removed. The logic of this change assumes that usize is at least 32-bit. This is technically a breaking change; note that `Range<usize>` and `Range<isize>` are always ExactSizeIterators. [breaking-change]
(fixes rust-lang#22317) rollupable
on crates and modules - replace ")" on more strings - improve readability of grapheme
Rename `libstd/failure.rs` to `libstd/panicking.rs` and `on_fail` to `on_panic`. Closes rust-lang#22306.
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: p=1 |
|
⌛ Testing commit 3ce2e0d with merge 0a58910... |
|
💔 Test failed - auto-linux-64-nopt-t |
|
⌛ Testing commit 3ae8b02 with merge 6a093e2... |
|
💔 Test failed - auto-win-32-opt |
|
closing in favor of #22367 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wordsfor now. #22253, Remove_VALUEfrom the float extremes constants. #22254, Rename the "unsafe" lang item to "unsafe_cell" #22262, Remove link to mailing list in bug report submission page #22263, Make if after colon lowercase #22264, Improve documentation forSelect::new(). #22268, Remove outdated information about copy/move from the reference #22269, Re-word paragraph about enums and equality #22271, Refer to LLVM rather than GCC wiki for atomic orderings #22272, Re-tagslicing_syntaxasAccepted. #22274, Add diverging functions to the book. #22275, Map clone #22276, Added all active features to the list in reference.md. #22277, Add#[rustc_error]annotation, which causes trans to signal an error #22278, Fix small copy-paste typo #22280, Don't specify tuple layout. #22284, Add link to module-level Option documentation. #22288, Enhance static mut example in FFI chapter. #22295, Remove ExactSizeIterator from 64-bit ranges. #22299, add test for #21909 #22302, Note that Vec<T> is heap allocated. #22305, clarfiy reference with regards to the value of block expressions #22307, Generate grammar.html and link to it from the reference. #22308, Normalize range syntax used in concurrency.md #22324, Correct typo #22328, Documentation Fixes #22329, Rename std::failure to std::panicking #22347