Replace some uses of deprecated os (mostly os::args) functions #22402
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| } else { | ||
| 10000 | ||
| }; | ||
|
|
||
| let m = if args.len() == 3 { | ||
| args[2].parse::<uint>().unwrap() | ||
| args.next().unwrap().parse::<usize>().unwrap() |
There was a problem hiding this comment.
This one is not as obvious as it was before, which possibly makes refactoring this file a little bit harder if we ever introduce breaking changes to env::args in the future.
Not sure how important it is, though.
This commit mostly replaces some of the uses of os::args with env::args.
nagisa
force-pushed
the
spring-cleanup-2
branch
from
f02cde4 to
7d941fa
Compare
|
Looks good to me! |
|
I'm going ahead and rolling this one up, ignoring the other PR, since in the rollup they'll all be together anyway. Let me know if I shouldn't. |
|
OK, I closed the other one. |
|
Thanks. I'll be sure to let you know if the rollup fails and it needs reopening :) |
…akis This commit mostly replaces some of the uses of os::args with env::args. This, for obvious reasons is based on top of rust-lang#22400. Do not r+ before that lands.
|
#22475 didn’t auto-close this somewhy… |
|
Probably because you pushed more changes here (which Alex may have included in a different form, i.e. a separate commit fixing issues in the other PRs). No need to worry about it 😄 |
This commit mostly replaces some of the uses of os::args with env::args.
This, for obvious reasons is based on top of #22400. Do not r+ before that lands.