Rolling up PRs in the queue #22475
Merged
Rolling up PRs in the queue #22475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without such a clarification, people who know and love closures (for instance programmers with a Haskell background) might fear that types would have to be declared in closures and that therefore using closures would be much more unwieldy.
This aligns json target specification to match terminology used elsewhere in the code base. [breaking-change] for custom target json users. Change all appearances of target-word-size to target-pointer-width.
The `Arguments::new_v1_formatted` function was accidentally left out when this module was stabilized.
Some newcomers might look for a "flatMap" method on Option. Include the reference so that searching the page would find "and_then".
When matching against strings/slices, we call the comparison function for strings, which takes two string slices by value. The slices are passed in memory, and currently we just pass in a pointer to the original slice. That can cause misoptimizations because we emit a call to llvm.lifetime.end for all by-value arguments at the end of a function, which in this case marks the original slice as dead. So we need to properly create copies of the slices to pass them to the comparison function. Fixes rust-lang#22008
The other cases: `concat_idents!`, `log_syntax!`, and `trace_macros!`, (these macros, with `asm!`, are handled (eagerly) in feature_gate.rs).
Requested by Niko in rust-lang#22200 (and is good to have anyway)
- We shouldn't be using `check_name` here at all - `contains_name(ref_slice(foo), bar)` is redundant, `contains_name` just iterates over its first arg and calls `check_name` - match would be better than a bunch of ifs
This redux of CONTRIBUTING.md adds in more information, including subsuming both compliment-bugreport.md and Note-development-policy in the wiki. I only glanced at the broad TOC of Note-development-policy, and did not use the text as the basis for the re-write. This will then address the last outstanding part of rust-lang#5831.
Fixes the crash blocking rust-lang#21886.
The test "signal_reported_right" send a signal `1` to `/bin/sh`, and check the status code to check if the signal is reported right. Under OpenBSD, the signal `1` (`SIGHUP`) is catched by `/bin/sh`, resulting the test failed. Use the uncatchable signal `9` (`SIGKILL`) for test.
This commit mostly replaces some of the uses of os::args with env::args.
Fixes rust-lang#19321
|
💔 Test failed - auto-linux-64-x-android-t |
|
@bors: r+ e9f42d7 p=100 |
|
⌛ Testing commit e9f42d7 with merge 04d7853... |
|
@bors: r+ d424224 p=1000 |
|
💔 Test failed - auto-linux-32-nopt-t |
|
@bors: retry |
|
⌛ Testing commit d424224 with merge 2badb94... |
|
💔 Test failed - auto-mac-64-nopt-t |
bors
added a commit
that referenced
this pull request
Feb 18, 2015
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors retry |
|
⌛ Testing commit 47f91a9 with merge eb836bf... |
|
💔 Test failed - auto-win-32-opt |
|
@bors retry |
|
(We'll merge this to master if http://buildbot.rust-lang.org/builders/auto-win-32-nopt-t/builds/3344 passes. Everything else except win32-opt and this have passed) |
|
win32-nopt passed. |
huonw
added a commit
that referenced
this pull request
Feb 18, 2015
One windows bot failed spuriously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.