-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change span_help calls to fileline_help where appropriate so as not to duplicate code snippets #22764
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
😍 |
This looks great, thanks! However, it can't be merged, and so needs a rebase. (Be sure to ping/@huonw me once you update it, github doesn't provide automatic notifications.) |
9343edb
to
1b70875
Compare
@huonw I've rebased and pushed. |
1b70875
to
64581cf
Compare
@bors r+ 6458 rollup |
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
(removed from the rollup, I'm on a phone and can't attempt to fix it, sorry) |
☔ The latest upstream changes (presumably #22801) made this pull request unmergeable. Please resolve the merge conflicts. |
Needs Manishearth@057aceb to pass tests |
64581cf
to
7496539
Compare
@huonw I've rebased again, since it was unmergeable. |
@bors r+ |
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
@bors: r- |
This still doesn't include the changes I listed above :/ Please ensure this passes Thanks! |
@Manishearth Sorry about that, should be fine now. |
When warnings and errors occur, the associated help message should not print the same code snippet. rust-lang#21938
@bors: r=huonw |
Rolled into #23031 |
When warnings and errors occur, the associated help message should not print the same code snippet.
#21938