Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change span_help calls to fileline_help where appropriate so as not to duplicate code snippets #22764

Closed
wants to merge 2 commits into from

Conversation

ivanradanov
Copy link
Contributor

When warnings and errors occur, the associated help message should not print the same code snippet.
#21938

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@nagisa
Copy link
Member

nagisa commented Feb 24, 2015

😍

@huonw
Copy link
Member

huonw commented Feb 24, 2015

This looks great, thanks! However, it can't be merged, and so needs a rebase.

(Be sure to ping/@huonw me once you update it, github doesn't provide automatic notifications.)

@ivanradanov
Copy link
Contributor Author

@huonw I've rebased and pushed.

@huonw
Copy link
Member

huonw commented Feb 26, 2015

@bors r+ 6458 rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Feb 26, 2015
When warnings and errors occur, the associated help message should not print the same code snippet.
rust-lang#21938
@Manishearth
Copy link
Member

@Manishearth
Copy link
Member

(removed from the rollup, I'm on a phone and can't attempt to fix it, sorry)

@bors
Copy link
Contributor

bors commented Feb 28, 2015

☔ The latest upstream changes (presumably #22801) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

Needs Manishearth@057aceb to pass tests

@ivanradanov
Copy link
Contributor Author

@huonw I've rebased again, since it was unmergeable.

@huonw
Copy link
Member

huonw commented Mar 4, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Mar 4, 2015

@bors r=huonw 7496539

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 4, 2015
 When warnings and errors occur, the associated help message should not print the same code snippet.
rust-lang#21938
@Manishearth
Copy link
Member

@bors: r-

@Manishearth
Copy link
Member

This still doesn't include the changes I listed above :/

Please ensure this passes check-stage1-cfail, specifically make check-stage1-cfail TESTNAME=issue-16747

Thanks!

@ivanradanov
Copy link
Contributor Author

@Manishearth Sorry about that, should be fine now.

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2015
 When warnings and errors occur, the associated help message should not print the same code snippet.
rust-lang#21938
Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 5, 2015
@alexcrichton
Copy link
Member

@bors: r=huonw

@bors
Copy link
Contributor

bors commented Mar 5, 2015

@bors r=huonw 21a5663

@alexcrichton
Copy link
Member

@bors: r=huonw 21a5663

@alexcrichton
Copy link
Member

Rolled into #23031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants