Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of PRs in the queue; Wednesday #23031

Merged
merged 47 commits into from
Mar 6, 2015
Merged

Conversation

Manishearth
Copy link
Member

No description provided.

iKevinY and others added 23 commits February 23, 2015 21:14
Since it makes more sense for .rs files to appear at the top of the
list of linted files and "other" files to appear at the end, this
commit moves the "other" count outside of the `file_counts` dictionary
and sorts the remaining "interesting" files by decreasing frequency.
- Replace wildcard import with explicit import of `check_license`
- Move more logic outside of the `try` block.
- Group all helper functions together.
- Define `interesting_exts` and `uninteresting_files` at start of file
  (with the rest of the constant declarations).
This handles the ranges contained in UnicodeData.txt.
Counterintuitively this actually makes the tables shorter.
This stability attribute was left out by accident and the stability pass has
since picked up the ability to check for this. As a result, crates are currently
getting warnings for implementations of `Index`.
This same source is being built in the Cargo ecosystem and hence needs to build
on stable Rust as well. This commit places the `no_std` attribute along with the
`no_std` feature behind a `cfg_attr` flag so they are not processed when
compiled on crates.io
The failing concurrency example was doing something different from the
working example. This commit changes just enough of the failing example
to (1) still fail with the same error, (2) tries to do the same as the
working example (increment a vector value and print it).

r? @steveklabnik
The docs for `std::duration::Duration::weeks` were formatted incorrectly.
@Manishearth
Copy link
Member Author

@bors: p=20 r+

@bors
Copy link
Contributor

bors commented Mar 4, 2015

@bors r=Manishearth 8697be6

I came across a couple of grammar mistakes when refreshing myself on enums.
bors added a commit that referenced this pull request Mar 4, 2015
@bors
Copy link
Contributor

bors commented Mar 4, 2015

⌛ Testing commit 8697be6 with merge 63d0ea2...

@bors
Copy link
Contributor

bors commented Mar 4, 2015

💔 Test failed - auto-mac-32-opt

@Manishearth
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Mar 5, 2015

⌛ Testing commit cffd661 with merge 2773a0b...

@bors
Copy link
Contributor

bors commented Mar 5, 2015

💔 Test failed - auto-linux-64-x-android-t

@Manishearth Manishearth force-pushed the rollup branch 2 times, most recently from 9957626 to 455aa62 Compare March 5, 2015 10:52
@Manishearth
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Mar 5, 2015

@bors r=Manishearth 340d1cc

@Manishearth
Copy link
Member Author

@bors: force

@bors
Copy link
Contributor

bors commented Mar 5, 2015

⌛ Testing commit 340d1cc with merge 85f8db1...

@bors
Copy link
Contributor

bors commented Mar 5, 2015

💔 Test failed - auto-linux-32-opt

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 5, 2015

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors
Copy link
Contributor

bors commented Mar 5, 2015

💔 Test failed - auto-win-64-opt

@Manishearth
Copy link
Member Author

@bors: retry force

@bors
Copy link
Contributor

bors commented Mar 5, 2015

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-x-android-t, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors
Copy link
Contributor

bors commented Mar 5, 2015

💔 Test failed - auto-win-32-opt

@alexcrichton
Copy link
Member

@bors: retry clean

@bors
Copy link
Contributor

bors commented Mar 5, 2015

⌛ Testing commit 340d1cc with merge b0746ff...

bors added a commit that referenced this pull request Mar 5, 2015
@alexcrichton
Copy link
Member

Another one bites the dust! Major props to @Manishearth 🍨

@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.