-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More editing work on TRPL #24244
More editing work on TRPL #24244
Conversation
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
||
Congratulations! You have officially written a Rust program. That makes you a | ||
Rust programmer! Welcome. | ||
Rust programmer! Welcome. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊🎉👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, maybe i should do that :)
|
||
This hasn’t bought us a whole lot over our simple use of `rustc`, but think | ||
about the future: when our project has more than one file, we would need to | ||
call `rustc` more than once and pass it a bunch of options to tell it to build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rustc
will load files as necessary for mod
s automatically (i.e. not like c/c++ compiler that makes per-file object files etc), so this statement is possibly not what you're trying to convey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking multi-crate stuff with dependencies. Thoughts on how to allude to that without saying it directly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll just go with 'more complex'
ece8fb5
to
06dc26d
Compare
Updated! |
Same here, to fix issues like #24252, I'm going to self-r+ these, if there's other nits, send an issue or PR ❤️ |
@bors: r+ rollup |
📌 Commit 06dc26d has been approved by |
…labnik Fill out blank section headers. Copy edit the entire first section.
…labnik Fill out blank section headers. Copy edit the entire first section.
…labnik Fill out blank section headers. Copy edit the entire first section.
…labnik Fill out blank section headers. Copy edit the entire first section.
…labnik Fill out blank section headers. Copy edit the entire first section.
…labnik Fill out blank section headers. Copy edit the entire first section.
☔ The latest upstream changes (presumably #24177) made this pull request unmergeable. Please resolve the merge conflicts. |
Fill out blank section headers. Copy edit the entire first section.
06dc26d
to
f01dbf2
Compare
@bors: r+ rollup |
📌 Commit f01dbf2 has been approved by |
…labnik Fill out blank section headers. Copy edit the entire first section.
…labnik Fill out blank section headers. Copy edit the entire first section.
Fill out blank section headers. Copy edit the entire first section.