-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 10 pull requests #24255
Closed
Closed
Rollup of 10 pull requests #24255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241.
Fill out blank section headers. Copy edit the entire first section.
A brief introduction to each type, with pointers to the primitive pages for more info.
…eklabnik rust-lang#24004 Something like this?
…labnik Now that the new TOC has landed, I've started doing an editing pass to get the old content into the right shape. I felt this introduction was significant enough to send as its own PR, though, as it's the introduction. It's possible that we may just want to replace 'the intro' with this directly, but this PR doesn't do that.
…labnik Fill out blank section headers. Copy edit the entire first section.
…failure, r=pnkfelix Don't use skolemized parameters but rather fresh variables in coherence. Skolemized parameters wind up preventing unification. Surprised we had no test for this! Fixes rust-lang#24241. r? @pnkfelix
…gs, r=huonw keeping on with the edits
…=alexcrichton A brief introduction to each type, with pointers to the primitive pages for more info.
@bors: r+ p=1 |
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
📌 Commit a92b4a4 has been approved by |
💔 Test failed - auto-linux-64-nopt-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
borrow
docs #24240, Indicate keyword in doc comment is code-like #24243, More editing work on TRPL #24244, Don't use skolemized parameters but rather fresh variables in coherence #24245, Copyediting for 'variable bindings' #24247, Write the 'primitive types' section of TRPL #24253