Skip to content

Conversation

@steveklabnik
Copy link
Contributor

Many unsafe features are now in the unstable section, so this section is
really just about raw pointers now. That also makes sense for its place
in the TOC.

This addresses part of #12905.

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ther -> their

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

Many unsafe features are now in the unstable section, so this section is
really just about raw pointers now. That also makes sense for its place
in the TOC.

This addresses part of rust-lang#12905.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file intended for deletion?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it effectively got moved to the other one. I'm working on a new, general 'unsafe' guide now, was just gonna send a different PR.

@alexcrichton
Copy link
Member

r=me if unsafe-code.md should be deleted, and also r=me if it shouldn't :)

@steveklabnik
Copy link
Contributor Author

@bors: r=alexcrichton rollup

@bors
Copy link
Collaborator

bors commented Apr 20, 2015

📌 Commit 1150fb0 has been approved by alexcrichton

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which two? & and &mut? or *const and *mut? It's seems to me that the raw pointer types are the least special (at least when compared to C/C++/other languages).

Also, I wouldn't call the raw pointer types "smart pointers".

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 21, 2015
…ichton

Many unsafe features are now in the unstable section, so this section is
really just about raw pointers now. That also makes sense for its place
in the TOC.

This addresses part of rust-lang#12905.
bors added a commit that referenced this pull request Apr 21, 2015
@bors bors merged commit 1150fb0 into rust-lang:master Apr 21, 2015
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 21, 2015
rust-lang#24631 is related, as it will delete this from the TOC, but I want to keep it here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants