-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refocus unsafe code chapter on unsafe itself. #24640
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ rollup |
📌 Commit e7111e7 has been approved by |
* Integer overflow | ||
|
||
Rust cannot prevent all kinds of software problems. Buggy code can and will be | ||
written in Rust. These things arne’t great, but they don’t qualify as `unsafe` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/arne/aren/
I assume you're intending to spread the content here into other sections? I feel like having a focused sub-guide for unsafe code (i.e. some organisation beyond just a pile of chapters mixed in with the rest of Syntax and Semantics or whatever) is useful: it is hard enough to write Maybe the organisation could be using this section as a landing page that links to all the other related sections? |
⌛ Testing commit e7111e7 with merge a3bb026... |
💔 Test failed - auto-win-32-nopt-t |
@bors: r=brson rollup |
📌 Commit e7111e7 has been approved by |
@huonw yes, a "Writing Safe Abstractions" chapter would be awesome in Effective Rust, but after moving most of what was in the unsafe guide to the unstable section, looking at this chapter, there's basically raw pointer stuff, and some comments about making unsafe things safer. In the new, semantics-oriented layout of these chapters, raw pointers deserve their own intro, and so does |
e7111e7
to
9cc0af8
Compare
@bors: r=brson rollup |
📌 Commit 9cc0af8 has been approved by |
@steveklabnik as long as you have a plan! (That plan sounds good to me.) |
rust-lang#24631 is related, as it will delete this from the TOC, but I want to keep it here.
#24631 is related, as it will delete this from the TOC, but I want to keep it here.