-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference Manual Chapter 8.1 #24744
Reference Manual Chapter 8.1 #24744
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
[^unittype]: The "unit" value `()` is *not* a sentinel "null pointer" value for | ||
reference variables; the "unit" type is the implicit return type from functions | ||
otherwise lacking a return type, and can be used in other contexts (such as | ||
message-sending or type-parametric code) as a zero-size type.] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, the unit type has actually been removed, ()
is only an empty tuple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, ok, that's the simplest way to go
Generally 👍 , but some nits! |
Will update with new commits, then squash after review. I don't mind lots of iterations. |
(Updated to address both nits) |
r=me after a squash, thanks so much! |
- Remove mention of unit type - Update closure types and reference types sections - Fix minor typos
Done, thanks for the feedback! |
@bors: r+ |
📌 Commit b22ea2d has been approved by |
@bors: rollup |
Audit & Edit Chapter 8.1 Types in reference manual - Remove mention of unit type - Update closure types and reference types sections - Fix minor typos
Audit & Edit Chapter 8.1 Types in reference manual