Skip to content

Conversation

@bluss
Copy link
Contributor

@bluss bluss commented Apr 23, 2015

Audit & Edit Chapter 8.1 Types in reference manual

  • Remove mention of unit type
  • Update closure types and reference types sections
  • Fix minor typos

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, the unit type has actually been removed, () is only an empty tuple.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ok, that's the simplest way to go

@steveklabnik
Copy link
Contributor

Generally 👍 , but some nits!

@bluss
Copy link
Contributor Author

bluss commented Apr 23, 2015

Will update with new commits, then squash after review. I don't mind lots of iterations.

@bluss
Copy link
Contributor Author

bluss commented Apr 24, 2015

(Updated to address both nits)

@steveklabnik
Copy link
Contributor

r=me after a squash, thanks so much!

- Remove mention of unit type
- Update closure types and reference types sections
- Fix minor typos
@bluss
Copy link
Contributor Author

bluss commented Apr 24, 2015

Done, thanks for the feedback!

@steveklabnik
Copy link
Contributor

@bors: r+

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

📌 Commit b22ea2d has been approved by steveklabnik

@steveklabnik
Copy link
Contributor

@bors: rollup

@bors
Copy link
Collaborator

bors commented Apr 24, 2015

⌛ Testing commit b22ea2d with merge 714bd49...

bors added a commit that referenced this pull request Apr 24, 2015
Audit & Edit Chapter 8.1 Types in reference manual

- Remove mention of unit type
- Update closure types and reference types sections
- Fix minor typos
@bors
Copy link
Collaborator

bors commented Apr 24, 2015

@bors bors merged commit b22ea2d into rust-lang:master Apr 24, 2015
@bluss bluss deleted the reference-1 branch April 24, 2015 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants