-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several Minor API / Reference Documentation Fixes #25290
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
thanks!! |
This says it can't be merged. Can you rebase? |
Rebased. Intelligently enough it conflicted with my own previous PR. |
@bors: r+ rollup |
📌 Commit aabdd8e has been approved by |
Thanks! |
Several Minor API / Reference Documentation Fixes - Fix a few small errors in the reference. - Fix paper cuts in the API docs. Fixes rust-lang#24882 Fixes rust-lang#25233 Fixes rust-lang#25250
Several Minor API / Reference Documentation Fixes - Fix a few small errors in the reference. - Fix paper cuts in the API docs. Fixes rust-lang#24882 Fixes rust-lang#25233 Fixes rust-lang#25250
Is it too late to get this backported? |
@frewsxcv i am backporting the entire book, reference, and grammar right before the release. |
👍 |
Several Minor API / Reference Documentation Fixes
Fixes #24882
Fixes #25233
Fixes #25250