-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the shown installed rust version to 1.0 #25493
Update the shown installed rust version to 1.0 #25493
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Could you fix the links as well (see #25489)? |
Done @Stebalien |
…rsion, r=alexcrichton Rust is out of beta 🎉 r? @steveklabnik
@alexcrichton Could you backport this to the 1.0 book? |
We do not do doc backports. |
@steveklabnik Why not? The link in the doc is wrong and this is the second person to download the wrong rust. |
There will always be things wrong in every release. You could also make the case that a new bug that gets fixed on master should be backported, because So, given that no software is perfect, you have to ask 'what's the criteria for backporting'? And, given that we already release new You could make an argument about backporting to 1.1, but we've decided generally to be very conservative with the stable branch. That's part of it being stable. I may end up doing a few particularly egregious fixes, like the table formatting in the stack and the heap, if that didn't make it in before beta, but that's only for 1.1: in general, after that, we won't be doing any doc backporting generally. |
Fair enough. |
Rust is out of beta 🎉
r? @steveklabnik