fs::walk_dir example without unstable features #25508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of the example won't compile due to unstable features. This is an attempt to fix that, at the cost of slightly more verbose code.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 17, 2015
…crichton The current version of the example won't compile due to unstable features. This is an attempt to fix that, at the cost of slightly more verbose code. Using rust 1.0.0 (a59de37). It might be obvious, but I'm not well versed with rust, so feedback is very welcome.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
May 30, 2016
Basically reverts rust-lang#25508. The `is_dir()` function has been stable since 1.5.0.
bors
added a commit
that referenced
this pull request
May 30, 2016
Use Path::is_dir() in fs::read_dir()'s example. Basically reverts #25508. The `is_dir()` function has been stable since 1.5.0.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 30, 2016
Use Path::is_dir() in fs::read_dir()'s example. Basically reverts rust-lang#25508. The `is_dir()` function has been stable since 1.5.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the example won't compile due to unstable features.
This is an attempt to fix that, at the cost of slightly more verbose code.
Using rust 1.0.0 (a59de37).
It might be obvious, but I'm not well versed with rust, so feedback is very welcome.