Two minor friendliness patches to ./configure #25697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Took me a moment to figure out that the appropriate response to "need program file" was to install the program named "file", not to think "If I didn't need the program file, why would I be compiling things?".
The `run` function passed its argument to `msg` via `"$@"`, but `msg` only printed its first argument. I think the intention was for `msg` to print all its arguments. (If not, `run` should only `msg "$1"`.)
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ rollup |
|
📌 Commit dfacdcf has been approved by |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
Make the error message about missing dependencies clearer, since "need program file" is pretty confusing, and make full commands get logged, since that seems to have been the intention.
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
Make the error message about missing dependencies clearer, since "need program file" is pretty confusing, and make full commands get logged, since that seems to have been the intention.
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
Make the error message about missing dependencies clearer, since "need program file" is pretty confusing, and make full commands get logged, since that seems to have been the intention.
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
Make the error message about missing dependencies clearer, since "need program file" is pretty confusing, and make full commands get logged, since that seems to have been the intention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the error message about missing dependencies clearer, since "need program file" is pretty confusing, and make full commands get logged, since that seems to have been the intention.