Let MultiItemDecorator take &Annotatable
#25710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was measured by |
Manishearth
changed the title
&Annotatable
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
…fackler fixes rust-lang#25683 I have a very nonscientific measurement of the data via valgrind/massif [here](https://gist.github.com/Manishearth/4c47f15f6835cb3957c4) I measured the memory usage for both --pretty=expanded and -Z no-trans It *seems* like there's a 20-25MB decrease during expansion on stage2 librustc; but I'm not quite sure. r? @eddyb (have not yet run tests, but it compiles fine, might want to wait before giving r+) cc @nrc @huon
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
…fackler fixes rust-lang#25683 I have a very nonscientific measurement of the data via valgrind/massif [here](https://gist.github.com/Manishearth/4c47f15f6835cb3957c4) I measured the memory usage for both --pretty=expanded and -Z no-trans It *seems* like there's a 20-25MB decrease during expansion on stage2 librustc; but I'm not quite sure. r? @eddyb (have not yet run tests, but it compiles fine, might want to wait before giving r+) cc @nrc @huon
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 23, 2015
…fackler fixes rust-lang#25683 I have a very nonscientific measurement of the data via valgrind/massif [here](https://gist.github.com/Manishearth/4c47f15f6835cb3957c4) I measured the memory usage for both --pretty=expanded and -Z no-trans It *seems* like there's a 20-25MB decrease during expansion on stage2 librustc; but I'm not quite sure. r? @eddyb (have not yet run tests, but it compiles fine, might want to wait before giving r+) cc @nrc @huon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #25683
I have a very nonscientific measurement of the data via valgrind/massif here
I measured the memory usage for both --pretty=expanded and -Z no-trans
It seems like there's a 20-25MB decrease during expansion on stage2 librustc; but I'm not quite sure.
r? @eddyb
cc @nrc @huon