Skip to content

Update doctest in comments.md #26073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2015
Merged

Update doctest in comments.md #26073

merged 1 commit into from
Jun 9, 2015

Conversation

chucksmash
Copy link
Contributor

For a user following the path of reading Chapter 5: Syntax & Symantics
prior to Chapter 4: Learn Rust, this will be the first time they have
encountered executable tests inside documentation comments.

The test will fail because the add_one function is not defined in
the context of the doctest. This might not be the optimal place to
introduce and explain the /// # notation but I think it is important
that this snippet pass as a test when rustdoc --test is run against
it.

For a user following the path of reading Chapter 5: Syntax & Symantics
prior to Chapter 4: Learn Rust, this will be the first time they have
encountered executable tests inside documentation comments.

The test will fail because the `add_one` function is not defined in
the context of the doctest. This might not be the optimal place to
introduce and explain the `/// #` notation but I think it is important
that this snippet pass as a test when `rustdoc --test` is run against
it if it is going to be shown.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

I think that because doctests are idiomatically shown as examples for library documentation it may make more sense to show the example of importing the add_one function instead of redefining it. Perhaps something like:

/// ```
/// use krate::add_one;
///
/// let five = 5;
/// assert_eq!(6, add_one(five));
/// ```

@steveklabnik
Copy link
Member

@alexcrichton that has the unfortunate property of turning an executable test into a non-executable test

@steveklabnik
Copy link
Member

@chucksmash I agree with you about the small concern regarding the # syntax. But for now, this is a strict improvement, so let's do it.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 8, 2015

📌 Commit 675b3de has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 9, 2015
…veklabnik

For a user following the path of reading Chapter 5: Syntax & Symantics
prior to Chapter 4: Learn Rust, this will be the first time they have
encountered executable tests inside documentation comments.

The test will fail because the `add_one` function is not defined in
the context of the doctest. This might not be the optimal place to
introduce and explain the `/// #` notation but I think it is important
that this snippet pass as a test when `rustdoc --test` is run against
it.
bors added a commit that referenced this pull request Jun 9, 2015
@bors bors merged commit 675b3de into rust-lang:master Jun 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants