Skip to content

doc: make explanation easier to undrstand #26976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2015
Merged

doc: make explanation easier to undrstand #26976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/librustc/diagnostics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,8 +791,7 @@ trait Foo {
fn bar(&self);
}

// we now declare a function which takes an object with Foo trait implemented
// as parameter
// we now declare a function which takes an object implementing the Foo trait
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that implements the Foo trait" is probably the right... tense..?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is correct, and it sounds better anyways... having which and that in a sentence sounds awkward.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really agree; but I do agree that this is unambiguously an improvement over the old wording.

fn some_func<T: Foo>(foo: T) {
foo.bar();
}
Expand Down