doc: make explanation easier to undrstand #26976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -791,8 +791,7 @@ trait Foo { | |||
| fn bar(&self); | |||
| } | |||
|
|
|||
| // we now declare a function which takes an object with Foo trait implemented | |||
| // as parameter | |||
| // we now declare a function which takes an object implementing the Foo trait | |||
There was a problem hiding this comment.
"that implements the Foo trait" is probably the right... tense..?
There was a problem hiding this comment.
I think this is correct, and it sounds better anyways... having which and that in a sentence sounds awkward.
There was a problem hiding this comment.
I don't really agree; but I do agree that this is unambiguously an improvement over the old wording.
|
@bor r+ rollup |
|
@bors: r=gankro rollup |
|
📌 Commit ef8c377 has been approved by |
|
🙇 |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 12, 2015
…=gankro That sentence make me read it a few times before properly understanding it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That sentence make me read it a few times before properly understanding it