Rollup of 6 pull requests #26985
Merged
Rollup of 6 pull requests #26985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Jul 12, 2015
Manishearth
commented
- Successful merges: librustdoc: generalise handling of keyboard shortcuts #26881, doc: remove playground links for structs and traits #26967, remove repetition from E0308 explanation #26973, core::option: obey idiom of leaving behind a trailing comma in match blocks #26974, doc: make explanation easier to undrstand #26976, doc: remove redundant info #26979
- Failed merges:
- It is clear that what follows are re-exports - There aren't so many re-exports that examples should be given
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=10 |
|
📌 Commit aad7cb8 has been approved by |
…=alexcrichton Avoids some code duplication and relies less on deprecated properties on `KeyboardEvent`. The code is still looking quite bad, but that’s primarily because interop in this area is a disaster zone.
The very first code fragment off every struct and trait documentation page generates wrong playground code. This pull request adjusts ```playpen.js``` to only create a link for real examples.
Documentation:
```rust
pub struct String {
// some fields omitted
}
```
Playground:
```rust
Struct std::String
[−]
[src]
```
r? @steveklabnik
…=gankro That sentence make me read it a few times before properly understanding it
- It is clear that what follows are re-exports - There aren't so many re-exports that examples should be given
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.