trans: Consolidate creating pass manager builders #27224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LTO pass in the compiler forgot to call the `LLVMRustAddBuilderLibraryInfo` function and configure other options such as merge_functions, vectorize_slp, etc. This ended up causing linker errors on MSVC targets because the optimizer didn't have the right knowledge that some system functions are missing on these platforms. This commit consolidates creation of PassManagerBuilder instances to one function which is then called when needed. This ensures that the pass manager is always correctly configured with the various target-specific information that LLVM needs. Overall, this fixes `-C lto -C opt-level=3` on 32-bit MSVC targets.
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @brson Also note that the diff looks a little better without looking at whitespace |
|
It's not obvious that you want to use the same inlining thresholds for the LTO optimization vs. regular compilation. |
|
I suppose, but that's also not really the point of this patch. Do you think it'll be harmful enough to separate out those parts? I suspect that nothing much will change as a result of this. |
|
It's probably harmless as long as we don't end up calling LLVMRustAddAlwaysInlinePass in LTO mode. |
|
@bors r+ |
|
📌 Commit 70e8220 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 23, 2015
The LTO pass in the compiler forgot to call the `LLVMRustAddBuilderLibraryInfo` function and configure other options such as merge_functions, vectorize_slp, etc. This ended up causing linker errors on MSVC targets because the optimizer didn't have the right knowledge that some system functions are missing on these platforms. This commit consolidates creation of PassManagerBuilder instances to one function which is then called when needed. This ensures that the pass manager is always correctly configured with the various target-specific information that LLVM needs. Overall, this fixes `-C lto -C opt-level=3` on 32-bit MSVC targets.
|
⌛ Testing commit 70e8220 with merge 69ca012... |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Nov 22, 2021
re-enable lto_build test on 32-bit MSVC re-enable lto_build test on 32-bit MSVC. Because rust-lang/rust#27224 landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LTO pass in the compiler forgot to call the
LLVMRustAddBuilderLibraryInfofunction and configure other options such as merge_functions, vectorize_slp,
etc. This ended up causing linker errors on MSVC targets because the optimizer
didn't have the right knowledge that some system functions are missing on these
platforms.
This commit consolidates creation of PassManagerBuilder instances to one
function which is then called when needed. This ensures that the pass manager is
always correctly configured with the various target-specific information that
LLVM needs.
Overall, this fixes
-C lto -C opt-level=3on 32-bit MSVC targets.