Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trans: Consolidate creating pass manager builders #27224

Merged
merged 1 commit into from
Jul 24, 2015

Commits on Jul 22, 2015

  1. trans: Consolidate creating pass manager builders

    The LTO pass in the compiler forgot to call the `LLVMRustAddBuilderLibraryInfo`
    function and configure other options such as merge_functions, vectorize_slp,
    etc. This ended up causing linker errors on MSVC targets because the optimizer
    didn't have the right knowledge that some system functions are missing on these
    platforms.
    
    This commit consolidates creation of PassManagerBuilder instances to one
    function which is then called when needed. This ensures that the pass manager is
    always correctly configured with the various target-specific information that
    LLVM needs.
    
    Overall, this fixes `-C lto -C opt-level=3` on 32-bit MSVC targets.
    alexcrichton committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    70e8220 View commit details
    Browse the repository at this point in the history